Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4647] Fix env_file handling #4805

Merged
merged 2 commits into from
Feb 12, 2025
Merged

[ENG-4647] Fix env_file handling #4805

merged 2 commits into from
Feb 12, 2025

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Feb 12, 2025

  • Import dotenv.load_dotenv early to avoid ImportError while loading rxconfig.py
  • Read ENV_FILE from the environment explicitly.

fix #4803

* Import dotenv.load_dotenv early to avoid ImportError while loading
  rxconfig.py
* Read ENV_FILE from the environment explicitly.

fix #4803
Copy link

linear bot commented Feb 12, 2025

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #4805 will not alter performance

Comparing masenf/env-file (37023c0) with main (289d10d)

Summary

✅ 8 untouched benchmarks

adhami3310
adhami3310 previously approved these changes Feb 12, 2025
Save enum fields as the enum object rather than the value.
@masenf masenf merged commit 3f68a27 into main Feb 12, 2025
42 of 43 checks passed
@masenf masenf deleted the masenf/env-file branch February 12, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading dotenv file displays warning, sometimes doesn't work
2 participants