Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark experimentation #4811

Merged
merged 5 commits into from
Feb 12, 2025
Merged

benchmark experimentation #4811

merged 5 commits into from
Feb 12, 2025

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #4811 will improve performances by 44.03%

Comparing benchmark-experimentation (bdf88d7) with main (dd5b817)

Summary

⚡ 6 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_page[_simple_page] 2.3 ms 2.2 ms +5.16%
test_compile_stateful[_complicated_page] 1.1 ms 1 ms +10.2%
test_compile_stateful[_simple_page] 379.3 µs 263.3 µs +44.03%
test_compile_stateful[_stateful_page] 470 µs 368.6 µs +27.51%
test_get_all_imports[_simple_page] 567.6 µs 495.3 µs +14.6%
test_evaluate_page[_simple_page] 2.9 ms 2.8 ms +3.23%

@masenf
Copy link
Collaborator

masenf commented Feb 12, 2025

is this new construct intended to not count the fixture execution?

@adhami3310
Copy link
Member Author

is this new construct intended to not count the fixture execution?

yes, more specifically, without it, it seems codspeed is measuring additional pytest overhead

Lendemor
Lendemor previously approved these changes Feb 12, 2025
Lendemor
Lendemor previously approved these changes Feb 12, 2025
@adhami3310 adhami3310 merged commit d79366d into main Feb 12, 2025
42 of 43 checks passed
@adhami3310 adhami3310 deleted the benchmark-experimentation branch February 12, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants