Stats reporting #33
Stats reporting #33
Conversation
|
Does this also set the stats protobuf somewhere, or is there code that does that already? It would be good to have corresponding code on the server / a plan for how we get these stats into gobbler/our infrastructure. Where do we plan to ultimately host the server for this? ec2? on the detector? |
|
I was thinking host on ec2. it doesn't need to be colocated with the station The stats info is set throughout the registration and connection process, but we can add things to the protobuf that we want to track. One thing I haven't added that would be good is failed decoys. |
| @@ -35,3 +40,36 @@ func Logger() *logrus.Logger { | |||
| }) | |||
| return logrusLogger | |||
| } | |||
|
|
|||
| func StatsReporting(stats *pb.SessionStats) { | |||
There was a problem hiding this comment.
There are lots of TODOs and commented out lines of code in this function.
Do we need all of them, or can we remove some?
tapdance/conjure.go
Outdated
|
|
||
| conn, err := registration.Connect(ctx) | ||
| if conn != nil && err == nil { | ||
| StatsReporting(cjSession.stats) |
There was a problem hiding this comment.
Make this a go routine as this will block the return of con to the user by a full tcp (tls) session
|
I've cleaned up commented code and TODOs, besides the one with regards to a stats endpoint for the protobuf reporting |
|
|
||
| conn, err := registration.Connect(ctx) | ||
| if conn != nil && err == nil { | ||
| go StatsReporting(cjSession.stats) |
There was a problem hiding this comment.
This is on me, but both cjSession, and registration track stats and I'm not sure exactly which of the stats we want to send via this channel. I think we probably want registration.stats. This is mostly an issue of deciding exactly what we want to track and send over this channel.
It may be worth opening a different issue to deal with this, as this change does complete the task of setting up the channel to communicate stats which is the issue that we opened here.
thoughts @nzimm?
There was a problem hiding this comment.
I think reporting the correct stats protobuf probably falls under the scope of this ticket.
I'm just not sure what is tracked differently between cjSession.stats and registration.stats
Report stats protobuf to station, over the socks5 address provided by Psiphon