Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Exit successfully if --duration limit is reached #3328

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[bugfix] Exit successfully if --duration limit is reached #3328

merged 2 commits into from
Dec 6, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 27, 2024

Also if --reruns or --duration is used, then failures are accounted from all runs.

Closes #3324.

@vkarak vkarak added this to the ReFrame 4.8 milestone Nov 27, 2024
@vkarak vkarak requested review from ekouts and teojgo November 27, 2024 18:08
@vkarak vkarak self-assigned this Nov 27, 2024
@vkarak vkarak requested a review from victorusu November 28, 2024 09:33
victorusu
victorusu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was unlinked from issues Dec 6, 2024
When running with --duration do not exit with a non-zero exit code just because of the time out of the last run #3324
Closed
Flexible node allocation does not work when Slurm constraints have a hyphen in their name #3325
Closed
@vkarak vkarak linked an issue Dec 6, 2024 that may be closed by this pull request
When running with --duration do not exit with a non-zero exit code just because of the time out of the last run #3324
Closed
@vkarak vkarak enabled auto-merge December 6, 2024 12:17
@vkarak vkarak merged commit 93eef0f into reframe-hpc:master Dec 6, 2024
38 checks passed
@vkarak vkarak deleted the bugfix/reruns-exitcode branch December 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorusu victorusu victorusu approved these changes

@ekouts ekouts Awaiting requested review from ekouts

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@vkarak vkarak

Labels
bugfix cli prio: normal
Projects
ReFrame Backlog
Status: Done
Milestone
ReFrame 4.8
2 participants
@vkarak @victorusu