Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulling in token patch and adding to surface example #194

Merged
merged 1 commit into from
Dec 16, 2024
Merged

pulling in token patch and adding to surface example #194

merged 1 commit into from
Dec 16, 2024

Conversation

mhewson
Copy link
Member

@mhewson mhewson commented Dec 13, 2024

Description

...

Checklist:

Design:

  • Reviewed with designer and meets expectations

Cross-browser testing:

  • Chrome
  • Firefox
  • Edge
  • Safari
  • iOS
  • Android

Unit testing:

  • Sufficient unit test coverage (see unit test best practices for ideas)
  • Snapshot updates are explained with comment and reference the relevant source code change

A11y:

  • Meets WCAG AA standards

Documentation:

  • API docs created/updated
  • Examples created/updated

@mhewson mhewson requested review from HeavyMedl and sikhote December 13, 2024 23:07
@mhewson mhewson merged commit dd95b01 into main Dec 16, 2024
3 checks passed
@mhewson mhewson deleted the pr/membership branch December 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikhote sikhote sikhote approved these changes

@HeavyMedl HeavyMedl Awaiting requested review from HeavyMedl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhewson @sikhote