Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-object-refinement #197

Merged
merged 21 commits into from
Jan 13, 2025
Merged

media-object-refinement #197

merged 21 commits into from
Jan 13, 2025

Conversation

sikhote
Copy link
Contributor

@sikhote sikhote commented Dec 26, 2024

Description

  • CdrChoreographer: updates to support more components
  • CdrLayout: always has container-type: inline-size; applied
  • CdrLayout: now accepts a containerName prop
  • CdrMediaObject: overlay works slightly differently, applying a media height and not relying on media's natural height
  • CdrMediaObject: applies media and content styles differently after use in other apps
  • CdrMediaObject: expanded examples
  • CdrMediaObject: changed some structure of sass mixins for easier reuse
  • CdrMediaObject: inner img, picture, video are applied display: block
  • CdrMediaObject" inner content has container-type: inline-size; applied for fluid content compatibility
  • interfaces: updates for accuracy

https://rei.github.io/rei-cedar/

@sikhote sikhote self-assigned this Dec 26, 2024
@sikhote sikhote marked this pull request as ready for review January 9, 2025 22:47
@c4rlosviteri c4rlosviteri self-requested a review January 13, 2025 22:46
@sikhote sikhote merged commit 5029e92 into main Jan 13, 2025
3 checks passed
@sikhote sikhote deleted the pr/media-object-refinement branch January 13, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants