Update Model Summary Visualization #209
Open
+40
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minor viz appearance.
There was a problem hiding this comment.
Hi Thomas, this all looks really good! I had just one comment, there doesn't seem to be a way to add back the loess for the daily logits using the plot_summary_graphs function. I'm not sure if we need a way to add back the loess, but it might be worth thinking about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an argument for LOESS curve visualization, changed LOESS parameters, minor change to visual appearance - (modified
alphafor points). Addresses issue #173.I added a toggle switch to remove the LOESS trend line in the summary plots. The functions for plotting will plot the trend line by default. However, the trend is no longer plotted by default on the daily logit plots when running the main function.
I experimented with some LOESS parameters with the intention of aiding visual trend analysis. It may turn out they're not good in some situations!
Lastly, I modified the opaqueness of the points plotted as I believe it's easier to see some details.