Convert RHUI product ID to list of IDs [RHELDST-28614] #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently created rhui tooling products and content sets caused issues for downstream tools, such as Manifest-API. This is because their download_urls contained "/rhui", which erroneously set the for_rhui property to true. This issue has been fixed, but we would like to extend the solution to make it more robust. This change adds a new rhui_product_ids entry to the schema, so we can compare against a list of IDs rather than a single one. This was done to avoid breaking changes.
amcmahon-rh
requested review from
rohanpm,
rbikar and
crungehottman
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently created rhui tooling products and content sets caused issues for downstream tools, such as Manifest-API. This is because their download_urls contained "/rhui", which erroneously set the for_rhui property to true.
This issue has been fixed, but we would like to extend the solution to make it more robust. This change adds a new rhui_product_ids entry to the schema, so we can compare against a list of IDs rather than a single one. This was done to avoid breaking changes.