Add exclusions for aliases [RHELDST-26013] #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcmahon-rh
requested review from
rohanpm,
negillett and
crungehottman
as code owners
rohanpm
reviewed
Nov 13, 2024
amcmahon-rh
force-pushed
the
exclude_paths
branch
from
a6df016 to
d343e94
Compare
amcmahon-rh
changed the title
amcmahon-rh
force-pushed
the
exclude_paths
branch
2 times, most recently
from
6866520 to
59dc1bf
Compare
rohanpm
reviewed
Nov 19, 2024
amcmahon-rh
force-pushed
the
exclude_paths
branch
from
fcc8cd1 to
e8e68b5
Compare
amcmahon-rh
changed the title
amcmahon-rh
force-pushed
the
exclude_paths
branch
from
704cd76 to
0dae54c
Compare
|
Is this ready for review now? I wasn't sure, because you added some log statements which were clearly for debugging and you didn't take them out again. |
Certain paths on our NetStorage fs have no symlinks/aliases, and teams/ tools that make use of these paths expect similar behaviour from exodus. This change introduces "exclude_paths" to exclude alias generation for certain paths, so we can replicate NetStorage behaviour.
amcmahon-rh
force-pushed
the
exclude_paths
branch
from
38d4f81 to
3b28ebd
Compare
for more information, see https://pre-commit.ci
|
I've updated the code again to remove the left over debug logs 😬 |
rohanpm
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain paths on our NetStorage fs have no symlinks/aliases, and teams/tools that make use of these paths expect similar behaviour from exodus.
This change introduces "exclude_paths" to exclude alias generation for certain paths, so we can replicate NetStorage behaviour.