Rollback when failed items exist [CLOUDDST-22013] (#238)

Also fixed a slow test.

pubtools/_quay/push_docker.py

@@ -741,8 +741,10 @@ def run(self) -> None:
             # Rollback only when all index image builds fails or there are failed items
             # Empty iib_results is not an error and shouldn't fail the push. The only exception is
             # when bundles presence check failed.
-            if (iib_results or bundles_presence_check_failed) and (
-                not any([x["iib_result"] for x in iib_results.values()]) or failed_items
+            if (
+                (iib_results or bundles_presence_check_failed)
+                and (not any([x["iib_result"] for x in iib_results.values()]))
+                or failed_items
             ):
                 if failed_items:
                     LOG.error("There are failed push items. Cannot continue, running rollback.")

tests/test_item_processor.py

@@ -165,7 +165,7 @@ def test_generate_existing_manifest_map_tolerate_429(operator_signing_push_item)
         source_registry="test-registry.io",
         reference_registries=["dest-registry.io"],
         reference_processor=rp,
-        extractor=ContentExtractor(quay_client=mock_client),
+        extractor=ContentExtractor(quay_client=mock_client, sleep_time=0),
     )
     assert ip.generate_existing_manifests_map(operator_signing_push_item) == {
         "test-registry.io": {