Fix SBOM pushing in ML merge workflow and remove field from SBOM #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues. Firstly, ML merging workflow can cause the SBOM pushing to raise an error in some cases. It happens when an old arch that doesn't have an SBOM is merged with new archs. Pubtools-quay attempts to find all arch SBOMs so that it can re-publish them for the ML digest. However, it cannot find an SBOM of the old arch, raising an error. The bug can be fixed by removing the error and tolerating that the ML SBOM will not contain SBOMs of every image arch. Secondly, each generated SBOM contains the "incompleteness_reasons" field, which is not a part of the CycloneDX spec and exists for internal use only. Remove this field from the SBOMs before publishing them to the final repos.
emilyzheng
approved these changes
May 9, 2024
midnightercz
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues.
Firstly, ML merging workflow can cause the SBOM pushing to raise an error in some cases. It happens when an old arch that doesn't have an SBOM is merged with new archs. Pubtools-quay attempts to find all arch SBOMs so that it can re-publish them for the ML digest. However, it cannot find an SBOM of the old arch, raising an error. The bug can be fixed by removing the error and tolerating that the ML SBOM will not contain SBOMs of every image arch.
Secondly, each generated SBOM contains the "incompleteness_reasons" field, which is not a part of the CycloneDX spec and exists for internal use only. Remove this field from the SBOMs before publishing them to the final repos.
Refers to:
CLOUDDST-22748
CLOUDDST-22739