feat(STONEINTG-1078): Unify the FBC validation tasks #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lcarva , fyi as well as we discussed the approach for this task change. |
I merged the FBC validation tasks in konflux-ci/build-definitions#1534 so that they no longer need to share a PVC. Since the `fbc-related-image-check` task requires the other two to be present, I am proposing a simplified rule of allowing either that task or the new `validate-fbc` task. Signed-off-by: arewm <[email protected]>
arewm
force-pushed
the
unify-fbc-check-tasks
branch
from
7620584 to
e084cdd
Compare
arewm
changed the title
|
Makes sense. Converting to draft to avoid accidental merge until konflux-ci/build-definitions#1534 is merged. |
|
This can be merged first as the EC policy would still be valid even if the other option was not a currently possible task, right? |
Yes, but I'd refrain from merging because |
lcarva
approved these changes
Dec 4, 2024
|
konflux-ci/build-definitions#1534 is in the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged the FBC validation tasks in
konflux-ci/build-definitions#1534 so that they no longer need to share a PVC. Since the
fbc-related-image-checktask requires the other two to be present, I am proposing a simplified rule of allowing either that task or the newvalidate-fbctask.