Add three new sast scans to required tasks #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an effective on date of March 1st to give people time to get them added them to their pipeline definitions. Note the tests will be required, meaning if they're not included EC will produce a "required task not found" violation, but they are "informative" only, meaning if they produce a failure status, EC will not produce a violation. I didn't add the new tasks to the fbc pipeline required task list since I think sast scans are likely not useful there, and because the existing sast-snyk-check scan is already not required for fbc. Handy queries to help confirm this change: yq '.pipeline-required-tasks | to_entries[].value |[.[0].tasks - .[1].tasks]' data/required_tasks.yml yq '.required-tasks|[.[0].tasks - .[1].tasks]' data/required_tasks.yml Ref: https://issues.redhat.com/browse/EC-887 Ref: https://issues.redhat.com/browse/EC-888 Ref: https://issues.redhat.com/browse/EC-889
|
I didn't remove the stale entries yet. |
Actually I'll save that for another PR. |
|
This might need a rebase on #96 (or vice versa). |
|
+1 to this change |
|
@simonbaird Is there any automation that will add the new tasks to existing build pipelines of projects that do builds in Konflux already? Or do we expect engineers to update all the pipeline definitions manually to insert the new tasks? |
|
|
FWIW I'd like to merge it, if only to close out the three Jiras on my scrum board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an effective on date of March 1st to give people time to get them added them to their pipeline definitions.
Note the tests will be required, meaning if they're not included EC will produce a "required task not found" violation, but they are "informative" only, meaning if they produce a failure status, EC will not produce a violation.
I didn't add the new tasks to the fbc pipeline required task list since I think sast scans are likely not useful there, and because the existing sast-snyk-check scan is already not required for fbc.
Handy queries to help confirm this change:
Ref: https://issues.redhat.com/browse/EC-887
Ref: https://issues.redhat.com/browse/EC-888
Ref: https://issues.redhat.com/browse/EC-889