relation: traits: Generalize the Circuit trait to work for all provers
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
force-pushed
the
joey/shared-gadgets
branch
from
e036d00 to
954c2ac
Compare
joeykraut
force-pushed
the
joey/shared-gadgets
branch
2 times, most recently
from
7bd1253 to
f7d74ea
Compare
akirillo
approved these changes
Nov 16, 2023
joeykraut
force-pushed
the
joey/shared-gadgets
branch
from
f7d74ea to
3e93f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactors the traits in the constraint system in two ways:
ConstraintSystemtrait, which previously captured shared functionality between proof systems, regardless of wiring types, was removed and merged intoCircuitCircuitis generalized to work over any choice of wiring type: i.e. over aFieldas well as anAuthenticatedScalarResultfor MPC provers.This allows us to implement shared functionality as default implementations on the
Circuittrait, so that provers may inherit more of the advanced circuitry without reimplementing.The motivation comes from the previously increasing disparity and overhead of implementing new shared functionality, and bugs that came from disparate implementations.
Testing