mpc-relation: constraint-system: Add interfaces for proof linking and gate layout #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
force-pushed
the
joey/proof-linking-interface
branch
from
6fa6ee8 to
b5e3eae
Compare
joeykraut
commented
Dec 27, 2023
Comment on lines
+137
to
+139
| link_groups: HashMap<String, Vec<Variable>>, | ||
| /// The offsets at which to place the link groups in the arithmetization | ||
| link_group_offsets: HashMap<String, usize>, |
There was a problem hiding this comment.
I will add the placement logic present in the single-prover implementation later. This is merely added to meet the new trait requirements.
joeykraut
force-pushed
the
joey/proof-linking-interface
branch
2 times, most recently
from
b300914 to
c4c7327
Compare
akirillo
approved these changes
Dec 27, 2023
joeykraut
force-pushed
the
joey/proof-linking-interface
branch
from
c4c7327 to
7a67ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds interfaces for proof linking and link group layout specification. The layout generation code is only implemented for the single-prover interface for the moment. The plan is to build that out and see how the design changes, before building out the multiprover interface.
Testing
renegade/circuitscrate