Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relation: constraint-system: Add proof-linking gates to arithmetization #37

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Dec 28, 2023

Purpose

This PR adds proof-linking gates to the arithmetization of a circuit when specified. This PR also adds tests for the previously written circuit layout code, as well as the proof-linking gate placement.

Testing

  • All unit tests pass

@joeykraut joeykraut force-pushed the joey/proof-linking-gates branch 3 times, most recently from cad8495 to e43c389 Compare December 28, 2023 23:24
@joeykraut joeykraut marked this pull request as ready for review December 28, 2023 23:25
@joeykraut joeykraut requested a review from akirillo December 28, 2023 23:25
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits, o/w lgtm

relation/src/constraint_system.rs Show resolved Hide resolved
relation/src/constraint_system.rs Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/proof-linking-gates branch from e43c389 to e9c4b42 Compare January 2, 2024 22:31
@joeykraut joeykraut merged commit 5dfd923 into main Jan 2, 2024
1 check failed
@joeykraut joeykraut deleted the joey/proof-linking-gates branch January 2, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants