Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: fix javascript trigger modal action example #249

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

souvikmishra
Copy link
Contributor

Description

In the deployed docs the "ethers actions" example threw me off, so I thought I'd just raise a quick PR for it.

  • Moved the highlighting to the buttons that are to be added, and,
  • removed the web-components from the markup

Tests

Umm, so bit of a bummer here actually I couldn't run this repo locally and have raised an issue for it so cannot check both the things below, you can check out the issue here btw.

  • - Ran the changes locally with Docusaurus. and confirmed that the changes appear as expected.
  • - Applied the corrections suggested by Cspell on the .mdx files with changes.

Preview/s

Umm, not sure if I can even trigger a preview XD

Oh and also, there wasn't any Contributing.md so I just raised the PR for main, lmk if there are any changes to be made to the branch or the PR, would be glad to do so.

P.S. Love the project, and happy to help! ❤️

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reown-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:37pm

Copy link
Collaborator

@rtomas rtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@rtomas rtomas merged commit 231f21c into reown-com:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants