Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase goldpinger timeouts and add goldpinger troubleshoot spec #4980

Merged
merged 12 commits into from
Dec 20, 2023
Merged

feat: increase goldpinger timeouts and add goldpinger troubleshoot spec #4980

merged 12 commits into from
Dec 20, 2023

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Dec 12, 2023

What this PR does / why we need it:

  • Increases goldpinger addon timeouts. In slowish networks, pings tend to fail unnecessarily. The default ping timeout is 300ms.
  • Add a support bundle spec whenever goldpinger addon is added to a kurl spec.

Which issue(s) this PR fixes:

Fixes #sc-91987

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

@banjoh banjoh requested a review from a team as a code owner December 12, 2023 10:42
@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.7.0-6.0.1-tests-2023-12-12T10:43:47Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.6.1-5.4.2-tests-2023-12-12T10:43:46Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.5.1-5.2.0-tests-2023-12-12T10:43:52Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.7.0-5.5.0-tests-2023-12-12T10:43:53Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.7.0-5.6.0-tests-2023-12-12T10:43:54Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.2.0-5.0.0-tests-2023-12-12T10:44:21Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.2.0-4.2.1-tests-2023-12-12T10:44:22Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.3.0-5.1.0-tests-2023-12-12T10:44:26Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-8fdd844-goldpinger-3.2.0-4.1.1-tests-2023-12-12T10:44:32Z

@banjoh banjoh changed the title Em/goldping timeouts and troubleshoot spec feat: goldping timeouts and troubleshoot spec Dec 12, 2023
@banjoh banjoh changed the title feat: goldping timeouts and troubleshoot spec feat: increase goldpinger timeouts and add goldpinger troubleshoot spec Dec 12, 2023
banjoh
banjoh commented Dec 12, 2023
View reviewed changes
addons/goldpinger/template/yaml/troubleshoot.yaml Outdated
@@ -0,0 +1,19 @@
apiVersion: v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testgrid tests are passing, but for some reason I cannot figure out how this troubleshoot.yaml spec is applied to the cluster when installing the add-on!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can guarantee that it's not being applied if it's only here in the template directory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is in template/yaml.

I have specific tests checking that the secret gets created and they are passing. It seems the secret gets applied, I just can't tell where that happens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean that the template directory is only used to generate the actual versioned addons - it's not included in the things being run on testgrid.

And template/yaml isn't a directory used by anything to the best of my knowledge - if you want this to be included in future versions it would need to be added to https://github.com/replicatedhq/kURL/tree/main/addons/goldpinger/template/base instead

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.7.0-5.5.0-tests-2023-12-12T17:22:21Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.7.0-6.0.1-tests-2023-12-12T17:22:23Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.5.1-5.2.0-tests-2023-12-12T17:22:25Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.7.0-5.6.0-tests-2023-12-12T17:22:27Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.6.1-5.4.2-tests-2023-12-12T17:22:29Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.3.0-5.1.0-tests-2023-12-12T17:23:01Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.2.0-5.0.0-tests-2023-12-12T17:22:59Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.2.0-4.2.1-tests-2023-12-12T17:23:08Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ea97452-goldpinger-3.2.0-4.1.1-tests-2023-12-12T17:23:12Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ac4b3bf-goldpinger-3.7.0-5.6.0-tests-2023-12-13T14:15:30Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ac4b3bf-goldpinger-3.7.0-6.0.1-tests-2023-12-13T14:15:33Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-ac4b3bf-goldpinger-3.6.1-5.4.2-tests-2023-12-13T14:15:35Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-a1f514c-goldpinger-3.2.0-4.1.1-tests-2023-12-14T19:00:23Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.7.0-5.6.0-tests-2023-12-14T21:35:43Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.5.1-5.2.0-tests-2023-12-14T21:35:45Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.7.0-5.5.0-tests-2023-12-14T21:35:48Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.7.0-6.0.1-tests-2023-12-14T21:35:48Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.6.1-5.4.2-tests-2023-12-14T21:35:50Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.2.0-5.0.0-tests-2023-12-14T21:36:20Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.2.0-4.2.1-tests-2023-12-14T21:36:24Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.2.0-4.1.1-tests-2023-12-14T21:36:28Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-aa7b85c-goldpinger-3.3.0-5.1.0-tests-2023-12-14T21:36:29Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.7.0-6.0.1-tests-2023-12-19T11:27:53Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.7.0-5.6.0-tests-2023-12-19T11:27:57Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.5.1-5.2.0-tests-2023-12-19T11:28:01Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.7.0-5.5.0-tests-2023-12-19T11:28:01Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.6.1-5.4.2-tests-2023-12-19T11:28:07Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.3.0-5.1.0-tests-2023-12-19T11:28:30Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.2.0-5.0.0-tests-2023-12-19T11:28:36Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.2.0-4.2.1-tests-2023-12-19T11:28:40Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-192f996-goldpinger-3.2.0-4.1.1-tests-2023-12-19T11:28:47Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-d154913-goldpinger-3.5.1-5.2.0-tests-2023-12-20T10:24:29Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-d154913-goldpinger-3.7.0-5.6.0-tests-2023-12-20T10:23:31Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-d154913-goldpinger-3.7.0-6.0.1-tests-2023-12-20T10:18:51Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-d154913-goldpinger-3.6.1-5.4.2-tests-2023-12-19T11:30:50Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4980-d154913-goldpinger-3.7.0-5.5.0-tests-2023-12-19T11:31:03Z

@banjoh banjoh merged commit cd3c8a1 into main Dec 20, 2023
13 of 14 checks passed
@banjoh banjoh deleted the em/goldping-timeouts-and-troubleshoot-spec branch December 20, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverya laverya laverya approved these changes

Assignees
No one assigned
Labels
goldpinger type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banjoh @laverya