Add command api to docs json #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's jam on this today (monday) |
lunaroyster
reviewed
Oct 30, 2023
modules/extensions/src/apis.json
Outdated
Comment on lines
148
to
159
| "typeNames": [ | ||
| "CommandFnArgs", | ||
| "CommandsFn", | ||
| "CreateCommand", | ||
| "Run", | ||
| "SerializableValue", | ||
| "BaseCommandArgs", | ||
| "ActionCommandArgs", | ||
| "ContextCommandArgs", | ||
| "CommandArgs", | ||
| "CommandProxy" | ||
| ] |
There was a problem hiding this comment.
commandproxy is an implementation detail, removed it
Suggested change
| "typeNames": [ | |
| "CommandFnArgs", | |
| "CommandsFn", | |
| "CreateCommand", | |
| "Run", | |
| "SerializableValue", | |
| "BaseCommandArgs", | |
| "ActionCommandArgs", | |
| "ContextCommandArgs", | |
| "CommandArgs", | |
| "CommandProxy" | |
| ] | |
| "typeNames": [ | |
| "CommandFnArgs", | |
| "CommandsFn", | |
| "CreateCommand", | |
| "Run", | |
| "SerializableValue", | |
| "BaseCommandArgs", | |
| "ActionCommandArgs", | |
| "ContextCommandArgs", | |
| "CommandArgs" | |
| ] |
|
In these docs it says that the commands API is experimental but I could only get it working via |
|
did you add the |
lunaroyster
force-pushed
the
dh-commands-docs
branch
from
e9a0d9a to
1cfbc82
Compare
|
rebased this to pick up docs generation test in CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally sure I'm doing this right, the docs setup is super confusing lol.