Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epmrpp 98957 #16

Merged
merged 36 commits into from
Jan 31, 2025
Merged

Feature/epmrpp 98957 #16

merged 36 commits into from
Jan 31, 2025

Conversation

EricesNicolas
Copy link
Contributor

@EricesNicolas EricesNicolas commented Jan 29, 2025

Summary of Changes
This PR updates the .github repository to improve and streamline reusable workflows for both Go and Java services. Key improvements include:

Refactored Go Build and Release Workflow:
Added support for dynamic service_name, enabling flexibility for services using the service-* prefix.
Ensured branch enforcement on master, preventing inconsistencies in releases.
Improved artifact handling to ensure correct naming and prevent duplicate uploads.
Enhanced error handling to manage cases where an asset already exists in a release.

Refactored Java Build and Release Workflow:
Introduced a reusable workflow for Java-based services, including:
Build automation using Gradle.
Authorization job to validate API keys and security credentials.
API service validation job to ensure that endpoints function correctly.
Added Pull Request (PR) support, allowing early validation before merging changes.
Enforced workflow execution on master to maintain consistency in releases.
Improved Workflow Structure and Reusability:

Optimized both workflows to be modular and scalable, reducing duplication and allowing for easier integration with different services.
Standardized environment variables and workflow inputs to enhance maintainability.

How to Use:
For Go and Java Services:
Trigger a release for a service-* Go service or java services and confirm that:
The workflow correctly builds the binary.
The artifact is named and uploaded correctly to the release.
No duplicate artifacts are created if a release already exists.

.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Show resolved Hide resolved
.github/workflows/go-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/go-build-release.yaml Show resolved Hide resolved
.github/workflows/java-build-release.yaml Show resolved Hide resolved
.github/workflows/java-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/java-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/java-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/java-build-release.yaml Outdated Show resolved Hide resolved
.github/workflows/java-build-release.yaml Outdated Show resolved Hide resolved
…s, make version of golang as an input, remove unused input
…, add java_version input, remove steps to check branch, add command to build instead of use an input
Copy link
Contributor

@raikbitters raikbitters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@hlebkanonik hlebkanonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@EricesNicolas EricesNicolas merged commit 34b5240 into main Jan 31, 2025
@EricesNicolas EricesNicolas deleted the feature/EPMRPP-98957 branch January 31, 2025 14:19
@EricesNicolas
Copy link
Contributor Author

merged into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants