-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/epmrpp 98957 #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: 12, Col: 11): Error from called workflow reportportal/.github/.github/workflows/java-build-release.yaml@feature/EPMRPP-98957 (Line: 27, Col: 13): Unexpected symbol: '+'.
…fferent from master for reuse
raikbitters
requested changes
Jan 29, 2025
raikbitters
requested changes
Jan 29, 2025
raikbitters
reviewed
Jan 29, 2025
raikbitters
reviewed
Jan 29, 2025
…s, make version of golang as an input, remove unused input
…, add java_version input, remove steps to check branch, add command to build instead of use an input
raikbitters
reviewed
Jan 30, 2025
raikbitters
reviewed
Jan 30, 2025
raikbitters
reviewed
Jan 30, 2025
raikbitters
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
hlebkanonik
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
merged into develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR updates the .github repository to improve and streamline reusable workflows for both Go and Java services. Key improvements include:
Refactored Go Build and Release Workflow:
Added support for dynamic service_name, enabling flexibility for services using the service-* prefix.
Ensured branch enforcement on master, preventing inconsistencies in releases.
Improved artifact handling to ensure correct naming and prevent duplicate uploads.
Enhanced error handling to manage cases where an asset already exists in a release.
Refactored Java Build and Release Workflow:
Introduced a reusable workflow for Java-based services, including:
Build automation using Gradle.
Authorization job to validate API keys and security credentials.
API service validation job to ensure that endpoints function correctly.
Added Pull Request (PR) support, allowing early validation before merging changes.
Enforced workflow execution on master to maintain consistency in releases.
Improved Workflow Structure and Reusability:
Optimized both workflows to be modular and scalable, reducing duplication and allowing for easier integration with different services.
Standardized environment variables and workflow inputs to enhance maintainability.
How to Use:
For Go and Java Services:
Trigger a release for a service-* Go service or java services and confirm that:
The workflow correctly builds the binary.
The artifact is named and uploaded correctly to the release.
No duplicate artifacts are created if a release already exists.