New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component update 5.11.1 #1956

Closed

APiankouski wants to merge 7 commits into master from hotfix/24.1.1

Contributor

APiankouski commented Mar 25, 2024

No description provided.


          EPMRPP-89755 || Sort parameters in alphabetical order

4d0e3e9

APiankouski requested a review from avarabyeu as a code owner

March 25, 2024 15:27

APiankouski and others added 2 commits

March 26, 2024 12:01


          EPMRPP-89932 || Add possibility to configure autocomplete suggestions…

6b0ec09

… when inviting users


          Merge pull request #1957 from reportportal/EPMRPP-89932

375862e

EPMRPP-89932 || Add possibility to configure autocomplete suggestions when inviting users

APiankouski temporarily deployed to rc

March 26, 2024 09:42

— with

GitHub Actions Inactive


          EPMRPP-89924 || Security vulnerabilities fix (#1958)

53f8a90

IvanKustau temporarily deployed to rc

March 28, 2024 09:09

— with

GitHub Actions Inactive

github-actions bot reviewed

View reviewed changes

src/main/java/com/epam/ta/reportportal/core/integration/plugin/impl/PluginLoaderImpl.java

                       .flatMap(it -> ofNullable(it.getDetails())).flatMap(
                           typeDetails -> IntegrationTypeProperties.VERSION.getValue(typeDetails.getDetails())
                               .map(String::valueOf)).ifPresent(
-                                  version -> BusinessRule.expect(version, v -> !v.equalsIgnoreCase(
-                              pluginInfo.getVersion()))
+                          version -> BusinessRule.expect(version, v -> !v.equalsIgnoreCase(pluginInfo.getVersion()))

github-actions bot Mar 28, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

src/main/java/com/epam/ta/reportportal/core/integration/plugin/impl/PluginLoaderImpl.java

@@ @@ -99,8 +99,7 @@ @@
                       .flatMap(it -> ofNullable(it.getDetails())).flatMap(
                           typeDetails -> IntegrationTypeProperties.VERSION.getValue(typeDetails.getDetails())
                               .map(String::valueOf)).ifPresent(
-                                  version -> BusinessRule.expect(version, v -> !v.equalsIgnoreCase(
-                              pluginInfo.getVersion()))
+                          version -> BusinessRule.expect(version, v -> !v.equalsIgnoreCase(pluginInfo.getVersion()))

github-actions bot Mar 28, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'lambda arguments' has incorrect indentation level 12, expected level should be one of the following: 18, 20.

src/main/java/com/epam/ta/reportportal/core/integration/plugin/PluginLoader.java

@@ @@ -35,9 +35,9 @@ public interface PluginLoader { @@
                  *
                  * @param pluginPath Plugin's path
                  * @return {@link PluginInfo} with {@link PluginInfo#getId()} and {@link PluginInfo#getVersion()}
-                 * @throws PluginException if there is an issue in loading the plugin or the plugin is not found in the specified path
+                 * @throws PluginRuntimeException if there is an issue in loading the plugin or the plugin is not found in the specified path

github-actions bot Mar 28, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 127).

src/test/java/com/epam/ta/reportportal/plugin/Pf4jPluginManagerTest.java

-                      Paths.get(PLUGINS_TEMP_PATH, NEW_PLUGIN_FILE_NAME))).thenThrow(new PluginException(
-                      "Manifest not found"));
+                      Paths.get(PLUGINS_TEMP_PATH, NEW_PLUGIN_FILE_NAME))).thenThrow(
+                      new PluginRuntimeException("Manifest not found"));

github-actions bot Mar 28, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'new' has incorrect indentation level 8, expected level should be one of the following: 10, 12.


          EPMRPP-89958 || Remove update of parent test item if it has status an… (

fbc5e29

#1960)

IvanKustau temporarily deployed to rc

April 1, 2024 08:21

— with

GitHub Actions Inactive


          EPMRPP-89932 || Add possibility to configure autocomplete suggestions…

00435ff

… when inviting users

APiankouski temporarily deployed to rc

April 1, 2024 10:32

— with

GitHub Actions Inactive

github-actions bot reviewed

View reviewed changes

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java Outdated

		@@ -77,14 +78,18 @@ public class GetProjectHandlerImpl implements GetProjectHandler {

		private final ProjectConverter projectConverter;

		private final boolean isUserSuggestions;

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java Outdated

		@@ -77,14 +78,18 @@

		private final ProjectConverter projectConverter;

		private final boolean isUserSuggestions;

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'member def modifier' has incorrect indentation level 8, expected level should be 2.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java Outdated

               	@Autowired
               	public GetProjectHandlerImpl(ProjectRepository projectRepository, UserRepository userRepository,
               			@Qualifier("projectJasperReportHandler") GetJasperReportHandler<ProjectInfo> jasperReportHandler,
-              			ProjectConverter projectConverter) {
+              			ProjectConverter projectConverter,

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java Outdated

               	@Autowired
               	public GetProjectHandlerImpl(ProjectRepository projectRepository, UserRepository userRepository,
               			@Qualifier("projectJasperReportHandler") GetJasperReportHandler<ProjectInfo> jasperReportHandler,
-              			ProjectConverter projectConverter) {
+              			ProjectConverter projectConverter,
+              			@Value("${rp.environment.variable.user.suggestions:true}") boolean isUserSuggestions) {

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 111).

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java Outdated

               	@Autowired
               	public GetProjectHandlerImpl(ProjectRepository projectRepository, UserRepository userRepository,
               			@Qualifier("projectJasperReportHandler") GetJasperReportHandler<ProjectInfo> jasperReportHandler,
-              			ProjectConverter projectConverter) {
+              			ProjectConverter projectConverter,
+              			@Value("${rp.environment.variable.user.suggestions:true}") boolean isUserSuggestions) {

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

               		return new CompositeFilterCondition(List.of(new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_USER),
               				new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_FULL_NAME),
               				new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_EMAIL)
               		), Operator.AND);
               	}
+              	private CompositeFilterCondition getUserSearchCondition(String value) {
+              		return new CompositeFilterCondition(List.of(
+              				new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 112).

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

               		return new CompositeFilterCondition(List.of(new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_USER),
               				new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_FULL_NAME),
               				new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_EMAIL)
               		), Operator.AND);
               	}
+              	private CompositeFilterCondition getUserSearchCondition(String value) {
+              		return new CompositeFilterCondition(List.of(
+              				new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

+              	private CompositeFilterCondition getUserSearchCondition(String value) {
+              		return new CompositeFilterCondition(List.of(
+              				new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
+              		), Operator.AND);

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

+              		return new CompositeFilterCondition(List.of(
+              				new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
+              		), Operator.AND);
+              	}

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

+              		return new CompositeFilterCondition(List.of(
+              				new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
+              		), Operator.AND);
+              	}

github-actions bot Apr 1, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def rcurly' has incorrect indentation level 8, expected level should be 2.

APiankouski changed the title ~~EPMRPP-89755 || Sort parameters in alphabetical order~~ Component update 5.11.1


          Fix test

d328565

APiankouski temporarily deployed to rc

April 2, 2024 12:54

— with

GitHub Actions Inactive

github-actions bot reviewed

View reviewed changes

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

+                @Value("${rp.environment.variable.user.suggestions:true}")
+                boolean isUserSuggestions;
+                @Autowired

github-actions bot Apr 2, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java

+                @Autowired
+                public GetProjectHandlerImpl(ProjectRepository projectRepository, UserRepository userRepository,
+                    @Qualifier("projectJasperReportHandler") GetJasperReportHandler<ProjectInfo> jasperReportHandler,

github-actions bot Apr 2, 2024

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

IvanKustau closed this

IvanKustau deleted the hotfix/24.1.1 branch

April 3, 2024 09:40

IvanKustau temporarily deployed to rc

April 3, 2024 09:40

— with

GitHub Actions Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet