Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix 5.11.1 #1969

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Hotfix 5.11.1 #1969

merged 9 commits into from
Apr 18, 2024

Conversation

IvanKustau
Copy link
Contributor

No description provided.

APiankouski and others added 9 commits March 25, 2024 18:24
@IvanKustau IvanKustau self-assigned this Apr 10, 2024
@IvanKustau IvanKustau requested a review from avarabyeu as a code owner April 10, 2024 10:49
github-actions[bot]
github-actions bot reviewed Apr 10, 2024
View reviewed changes
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java
@@ -121,7 +125,7 @@ void getUserNamesByIncorrectTerm() {

@Test
void getUserNamesNegative() {
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("",
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("", UserRole.ADMINISTRATOR,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 146).

src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java
@@ -121,7 +125,7 @@

@Test
void getUserNamesNegative() {
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("",
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("", UserRole.ADMINISTRATOR,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java
@@ -121,7 +125,7 @@

@Test
void getUserNamesNegative() {
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("",
ReportPortalException exception = assertThrows(ReportPortalException.class, () -> handler.getUserNames("", UserRole.ADMINISTRATOR,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 16, expected level should be 4.

src/test/java/com/epam/ta/reportportal/plugin/Pf4jPluginManagerTest.java
Paths.get(PLUGINS_TEMP_PATH, NEW_PLUGIN_FILE_NAME))).thenThrow(new PluginException(
"Manifest not found"));
Paths.get(PLUGINS_TEMP_PATH, NEW_PLUGIN_FILE_NAME))).thenThrow(
new PluginRuntimeException("Manifest not found"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'new' has incorrect indentation level 8, expected level should be one of the following: 10, 12.

src/main/java/com/epam/ta/reportportal/core/integration/plugin/PluginLoader.java
@@ -35,9 +35,9 @@ public interface PluginLoader {
*
* @param pluginPath Plugin's path
* @return {@link PluginInfo} with {@link PluginInfo#getId()} and {@link PluginInfo#getVersion()}
* @throws PluginException if there is an issue in loading the plugin or the plugin is not found in the specified path
* @throws PluginRuntimeException if there is an issue in loading the plugin or the plugin is not found in the specified path
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 127).

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java
return new CompositeFilterCondition(List.of(new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_USER),
new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_FULL_NAME),
new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_EMAIL)
), Operator.AND);
}

private CompositeFilterCondition getUserSearchCondition(String value) {
return new CompositeFilterCondition(List.of(
new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 112).

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java
return new CompositeFilterCondition(List.of(new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_USER),
new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_FULL_NAME),
new FilterCondition(Operator.OR, Condition.CONTAINS, false, value, CRITERIA_EMAIL)
), Operator.AND);
}

private CompositeFilterCondition getUserSearchCondition(String value) {
return new CompositeFilterCondition(List.of(
new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java
private CompositeFilterCondition getUserSearchCondition(String value) {
return new CompositeFilterCondition(List.of(
new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
), Operator.AND);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java
return new CompositeFilterCondition(List.of(
new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
), Operator.AND);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java
return new CompositeFilterCondition(List.of(
new FilterCondition(Operator.OR, Condition.EQUALS, false, value, CRITERIA_EMAIL)
), Operator.AND);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 8, expected level should be 2.

@IvanKustau IvanKustau merged commit b39dadd into master Apr 18, 2024
8 checks passed
@IvanKustau IvanKustau deleted the hotfix/5.11.1 branch April 18, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@APiankouski APiankouski APiankouski approved these changes

@grabsefx grabsefx grabsefx approved these changes

@pbortnik pbortnik pbortnik approved these changes

@avarabyeu avarabyeu Awaiting requested review from avarabyeu avarabyeu is a code owner

Assignees

@IvanKustau IvanKustau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanKustau @pbortnik @grabsefx @APiankouski