feat: implement treat-canonical-paths-equal flag #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
canonical_paths
branch
from
ffc0c5c to
bcadcde
Compare
AkihiroSuda
reviewed
Mar 4, 2024
AkihiroSuda
reviewed
Mar 4, 2024
AkihiroSuda
reviewed
Mar 4, 2024
|
Could you squash the commits? |
thesayyn
force-pushed
the
canonical_paths
branch
from
a3d25ab to
03c204e
Compare
|
Done |
AkihiroSuda
reviewed
Mar 4, 2024
AkihiroSuda
reviewed
Mar 4, 2024
Signed-off-by: thesayyn <[email protected]> rename flag Update cmd/diffoci/commands/diff/diff.go Co-authored-by: Akihiro Suda <[email protected]> Signed-off-by: thesayyn <[email protected]>
thesayyn
force-pushed
the
canonical_paths
branch
from
e760f0a to
11e3981
Compare
|
Done, PTAL |
AkihiroSuda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tars extracted, essentially `` (no prefix) ,
/(leading slash), `./` (dot slash) all mean the same thing, relative to `chroot` of the container.This flag implements a feature where these paths are considered the same.
I didn't add any tests, as i didn't know where to put them.