dojson: fix physical description for page count

* Adds the text "pages" for the pysical description of page count. * Fixes the creation of physical descriptions if the page count is 0. Co-Authored-by: Peter Weber <[email protected]>
rero · May 27, 2019 · 0c9f685 · 0c9f685
1 parent 04648ac
commit 0c9f685
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/rero_ebooks/dojson/json/model.py b/rero_ebooks/dojson/json/model.py
@@ -175,12 +175,17 @@ def publisher_name(self, key, value):
 @cantook_json.over('physical_description', 'page_count')
 @utils.for_each_value
 @utils.filter_values
+@utils.ignore_value
 def physical_description(self, key, value):
     """Physical description transformation.
 
     extent (Number of physical pages, volumes...): Marc21 300 $a field.
     """
-    return {'extent': str(value)}
+    extent = None
+    if int(value) != 0:
+        pages = "{value} pages".format(value=value)
+        extent = {'extent': pages}
+    return extent
 
 
 @cantook_json.over('summary', 'summary')

diff --git a/tests/unit/test_dojson.py b/tests/unit/test_dojson.py
@@ -160,7 +160,7 @@ def test_json_physical_description():
     }
     assert cantook_json.do(data) == {
         '__order__': ['physical_description'],
-        'physical_description': [{'extent': '1234'}]
+        'physical_description': [{'extent': '1234 pages'}]
     }