Fix z-index so tooltips are above #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2561 ↗︎
Details:
Review all test suite changes for PR #2803 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2803 +/- ##
===========================================
+ Coverage 86.26% 86.41% +0.14%
===========================================
Files 251 248 -3
Lines 8441 8426 -15
Branches 2653 2653
===========================================
- Hits 7282 7281 -1
+ Misses 1075 1062 -13
+ Partials 84 83 -1 ☔ View full report in Codecov by Sentry. |
lmcnulty
reviewed
May 31, 2024
| @@ -24,7 +24,7 @@ const Layout = ({ children, className, sidebarCollapsed = false, location }) => | |||
| <div | |||
| id="content" | |||
| className={ | |||
| 'flex flex-grow pt-4 px-4 pb-5 md:px-10 md:pb-10 z-[1] relative flex-1 overflow-clip' + | |||
| 'flex flex-grow pt-4 px-4 pb-5 md:px-10 md:pb-10 z-1 relative flex-1 overflow-clip' + | |||
There was a problem hiding this comment.
Does z-1 actually do anything? It seems like Tailwind jumps from z-0 to z-10 for whatever reason.
There was a problem hiding this comment.
Right! I was convinced it was z-index: 1
I just removed it because it wasn't doing anything.
It seems to work ok that way so I think we're good, but let me know if you find anything weird or not working properly regarding tooltips and others.
lmcnulty
approved these changes
Jun 3, 2024
|
Polite ping on this PR. Good to merge? |
|
@kepae yes good to go! |
clari182
merged commit 6db0e29
into
responsible-ai-collaborative:staging
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not break #2164
https://pr-2803--staging-aiid.netlify.app/