Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "subscribe" to "sign up" #2821

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Jun 6, 2024

Per #2818.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.33%. Comparing base (03afdc3) to head (24292c3).
Report is 3 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #2821   +/-   ##
========================================
  Coverage    99.33%   99.33%           
========================================
  Files           12       12           
  Lines         4845     4845           
  Branches        25       41   +16     
========================================
  Hits          4813     4813           
  Misses          32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kepae kepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this. Could you please check the translation coverage?

@lmcnulty
Copy link
Collaborator Author

@kepae Yes, it's covered in all four languages in site/gatsby-site/i18n/locales/{locale}/login.json.

@lmcnulty lmcnulty merged commit ab52d10 into responsible-ai-collaborative:staging Jul 1, 2024
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants