Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually keep track of connections #2824

Conversation

cesarvarela
Copy link
Collaborator

closes #2816 (hopefully this time)

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.46%. Comparing base (8af47c9) to head (ca6036a).
Report is 1 commits behind head on staging.

Files Patch % Lines
site/gatsby-site/server/schema.ts 92.45% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2824      +/-   ##
===========================================
+ Coverage    99.33%   99.46%   +0.12%     
===========================================
  Files           12       12              
  Lines         4843     4893      +50     
  Branches        41       55      +14     
===========================================
+ Hits          4811     4867      +56     
+ Misses          31       24       -7     
- Partials         1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cesarvarela
Copy link
Collaborator Author

Turns out aliases were broken 🤯

There are some reports of this same issue in the graphq-tools repo:

ardatan/graphql-tools#5262

Using stichSchemas instead of mergeSchemas fixes it so 🤷

@cesarvarela
Copy link
Collaborator Author

@pdcp1 ready for another round

@cesarvarela cesarvarela merged commit ad4bbf0 into responsible-ai-collaborative:staging Jun 11, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants