Change WebArchiveLink component to simplify snapshot URL fetching #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd update tests for archive link functionality
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3334 +/- ##
========================================
Coverage 96.13% 96.13%
========================================
Files 65 65
Lines 13020 13020
Branches 223 223
========================================
Hits 12517 12517
Misses 503 503 ☔ View full report in Codecov by Sentry. |
cesarvarela
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3328
The reason for the test failure
The Wayback Archive site indexed a new version of the testing report URL (https://www.cbsnews.com/news/is-starbucks-shortchanging-its-baristas/) on
2025-01-17that invalidates the hardcoded expected URL timestamp