Feature/submitted bulk actions #3350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… submissions in SubmissionList component
pdcp1
requested changes
Feb 7, 2025
| setSelectedRows(newSelection); | ||
| }; | ||
|
|
||
| // Function to check if all rows are selected |
There was a problem hiding this comment.
Please change this filter code for something like more clear like:
selectedRows.filter()
| }, | ||
| }); | ||
| } | ||
| columns = columns.concat([ |
There was a problem hiding this comment.
Utilize columns.push to maintain consistency.
|
|
||
| const bulkActions = async () => { | ||
| try { | ||
| const selectedSubmissions = Object.keys(selectedRows).filter( |
There was a problem hiding this comment.
Please change to selectRows.filter
| const addToast = useToastContext(); | ||
|
|
||
| const [selectedRows, setSelectedRows] = useState({}); |
There was a problem hiding this comment.
I believe selectedRows should be an array of objects rather than a single object.
| ); | ||
|
|
||
| if (selectedSubmissions.length > 0) { | ||
| if (selectedAction === 'claim') { |
There was a problem hiding this comment.
Could you please refactor this code to extract three different functions for each action (claim, unclaim, and reject)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URL: https://pr-3350--staging-aiid.netlify.app/