Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default path on Windows #157

Closed
Enrico204 opened this issue Aug 23, 2021 · 4 comments
Closed

Wrong default path on Windows #157

Enrico204 opened this issue Aug 23, 2021 · 4 comments

Comments

@Enrico204
Copy link
Contributor

Output of rest-server --version

rest-server version rest-server 0.10.0-dev compiled with go1.17 on windows/amd64
(latest on master)

How did you run rest-server exactly?

rest-server.exe --no-auth

What backend/server/service did you use to store the repository?

Local directory

Expected behavior

rest-server start pointing to a temporary directory (like the Linux version)

Actual behavior

rest-server start pointing to /tmp/restic, which is being translated to \tmp\restic by Go, which in turn is invalid (at least, it doesn't exist in a standard Windows installation)

Steps to reproduce the behavior

Just start rest-server --no-auth in a clean Windows installation.

Do you have any idea what may have caused this?

Wrong default path for Windows platform, caused by hardcoded ref to /tmp/restic here:

Path: "/tmp/restic",

Do you have an idea how to solve the issue?

Use os.TempDir() to retrieve the platform-specific temporary directory.

Did rest-server help you today? Did it make you happy in any way?

Yes! I'm using rest-server on daily basis as backend for my personal backups :-D

@wojas
Copy link
Contributor

wojas commented Aug 23, 2021

We plan to remove the default path in a future release and make it a required argument.

@Enrico204
Copy link
Contributor Author

Ah ok, good. Do we already have an issue to track that change?

@wojas
Copy link
Contributor

wojas commented Aug 24, 2021

Not currently, it may be added as part of PR #140.

@Enrico204
Copy link
Contributor Author

Fixed in pull request #158 , closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants