Use os.TempDir() for temporary directory in default path #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #157, we plan to remove the default path in a future release and make it a required argument. |
There was a problem hiding this comment.
@wojas: Do you have objections to cleanup the default path calculation for now until we're ready to change how the rest-server is configured?
No, go ahead. It's just that having a default that eats your backups is not great anyway. |
|
I changed the code according to the review (except for the comment on the command line help section) :-) |
Enrico204
force-pushed
the
use-os-tempdir-for-temporary-directory
branch
from
a933653 to
40bb1eb
Compare
|
I've rebased this pull request to the current |
MichaelEischer
force-pushed
the
use-os-tempdir-for-temporary-directory
branch
from
40bb1eb to
f952bc7
Compare
MichaelEischer
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
This pull request removes the hardcoded reference to
/tmp/resticreplacing with platform-specific path, retrieved usingos.TempDir()stdlib function.Was the change discussed in an issue or in the forum before?
Issue #157
Checklist
os.TempDir()is a builtin functionchangelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits