Add support for 1.16.1 join game codec (fix error)

retrooper · Oct 28, 2024 · 5247ccd · 5247ccd
1 parent f66626a
commit 5247ccd
Showing 1 changed file with 19 additions and 9 deletions.
diff --git a/...n/java/com/github/retrooper/packetevents/util/mappings/SynchronizedRegistriesHandler.java b/...n/java/com/github/retrooper/packetevents/util/mappings/SynchronizedRegistriesHandler.java
@@ -128,15 +128,25 @@ public static void handleLegacyRegistries(
     ) {
         Object cacheKey = PacketEvents.getAPI().getServerManager().getRegistryCacheKey(user, version);
         for (NBT tag : registryData.getTags().values()) {
-            NBTCompound compound = (NBTCompound) tag;
-            // extract registry name
-            ResourceLocation registryName = new ResourceLocation(compound.getStringTagValueOrThrow("type"));
-            // extract registry entries
-            NBTList<NBTCompound> nbtElements = compound.getCompoundListTagOrNull("value");
-            if (nbtElements != null) {
-                // store registry elements
-                handleRegistry(user, version, registryName,
-                        RegistryElement.convertNbt(nbtElements), cacheKey);
+            //On 1.16 they send an NBTList for dimension.
+            if (tag instanceof NBTList) {
+                NBTList<NBTCompound> list = (NBTList<NBTCompound>) tag;
+                handleRegistry(user, version, DimensionTypes.getRegistry().getRegistryKey(),
+                        RegistryElement.convertNbt(list), cacheKey);
+
+            }
+            //Newer versions
+            else {
+                NBTCompound compound = (NBTCompound) tag;
+                // extract registry name
+                ResourceLocation registryName = new ResourceLocation(compound.getStringTagValueOrThrow("type"));
+                // extract registry entries
+                NBTList<NBTCompound> nbtElements = compound.getCompoundListTagOrNull("value");
+                if (nbtElements != null) {
+                    // store registry elements
+                    handleRegistry(user, version, registryName,
+                            RegistryElement.convertNbt(nbtElements), cacheKey);
+                }
             }
         }
     }