Added WrapperPlayServerSculkVibrationSignal #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrooper
requested changes
May 19, 2022
|
I will test it today or tomorrow. |
…estinationIdentifier`
|
Does it work on 1.8? |
|
No. Sculks were introduced on newer versions. |
retrooper
requested changes
May 29, 2022
There was a problem hiding this comment.
On wiki.vg it says the "destination" (field after the destination identifier) can either be a VarInt ENTITY ID or a Long encoded block position. So this code might not always work? https://wiki.vg/Protocol#Sculk_Vibration_Signal
|
Yea but I don't know under which circumstances. I tested it for a few time and haven't received any errors or such. |
|
Have you checked minecraft's vanilla code? |
|
I'll check. |
|
Depends on the identifier. I think the identifier can either be "minecraft:entity" or "minecraft:block" according to vanilla code. |
|
But I'd say do some debugging too. |
|
Alright, will do it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.vg/Protocol#Sculk_Vibration_Signal
Tested Server-Versions: 1.18.2