Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.3/1.20.4 update #623

Merged
merged 31 commits into from
Dec 12, 2023
Merged

1.20.3/1.20.4 update #623

merged 31 commits into from
Dec 12, 2023

Conversation

booky10
Copy link
Collaborator

@booky10 booky10 commented Nov 17, 2023 •
edited
Loading

Ofc still very much WIP, 1.20.3 doesn't even have pre-releases yet isn't released yet.

There is a major change to the protocol, components are now serialized as NBT instead of JSON.

(https://gist.github.com/booky10/e2a3682b114900f70c89c0dc12da483e has some code I've used for extracting data from vanilla)

booky10 added 28 commits November 16, 2023 18:21
@booky10
Add new packet types
593015d
@booky10
Add block mappings for 1.20.3
33abe17
@booky10
Fix names of command argument parsers
51abf38
@booky10
Add dummy "style" command argument parser
5272557
@booky10
Implement packet wrappers for new clientbound packets
65fba0b
@booky10
Implement packet wrappers for new serverbound packets
5a49cf2
@booky10
Update serverbound jigsaw block packet
513de88
@booky10
Use nbt-based component read/write methods
b2e47f4
@booky10
Fix blockstate registry index not being incremented
3bdd110
@booky10
Update vibration particle data
abea905
@booky10
Update explosion packet
f863ad0
@booky10
Add new game state change "reasons"
ae1a025
@booky10
Add breeze and wind charge entity types
a0096b3
@booky10
Add new particle types
39f9ed0
@booky10
Add new item types
a624a76
@booky10
WIP new state types
f7d5252
@booky10
Fix missing fields for state types
945ca46
@booky10
Update block/item tags to 1.20.3
cbfca6c 
Also fixes incorrect ordering
@booky10
Move new entitytypes to bottom
6e30fb3
@booky10
Update packet ids for 1.20.3-pre1
828013b
@booky10
Update packet structures for 1.20.3-pre1
fd1b918
@booky10
Rename grass to short_grass for 1.20.3-pre1
2da4218
@booky10
Add new resourcepack status for 1.20.3-pre3
667652b
@booky10
Fix wrong config packet type registration
fca9ad2
@booky10
Some various fixes for packet wrappers
8b85bc8
@booky10
Add crafting and trial_spawner_state state values
e17b877
@booky10
Fix new particle type ids being ignored
24838cd
@booky10
Fix NPE for adventure nbt deserialization if no translation args are …
4ef8b38 
…present
@booky10
Copy link
Collaborator Author

booky10 commented Dec 5, 2023

I've tested most of the new stuff, works on spigot 1.20.3.

@booky10 booky10 marked this pull request as ready for review December 5, 2023 19:48
@AoElite
Copy link
Contributor

AoElite commented Dec 6, 2023

@booky10 Have you tested it on older server versions as well?

@retrooper
* Added 1.20.4 version constants
3e828ea 
* GRASS -> SHORT_GRASS, but GRASS is deprecated.
* WrapperPlayServerTickingInfo -> WrapperPlayServerTickingState
* WrapperPlayServerTickingStep minor changes
@retrooper
Copy link
Owner

in the new NBT-Serializer for Components there's this one bug on 1.20.3/1.20.4 https://pastebin.com/mzM8TtRg

@booky10 booky10 changed the title 1.20.3 update 1.20.3/1.20.4 update Dec 8, 2023
@booky10
Rewrite adventure nbt serialization
6c5d9be 
This will now skip building nbt objects and will directly build adventure components
@booky10
Add handling for unnamed simple components as serialized compounds
30ff648
@booky10
Copy link
Collaborator Author

booky10 commented Dec 9, 2023

@booky10 Have you tested it on older server versions as well?

I've did some short tests (especially regarding component serialization) in 1.8.8, 1.12.2, 1.16.5, 1.20.1 and 1.20.2. Everything I've tested is working.

@KaspianDev KaspianDev mentioned this pull request Dec 11, 2023
Closed
@retrooper retrooper merged commit 1e91905 into retrooper:2.0 Dec 12, 2023
1 check passed
@booky10 booky10 deleted the dev/1.20.3 branch December 12, 2023 21:46
@retrooper
Copy link
Owner

Thank you for the PR!

@booky10 booky10 restored the dev/1.20.3 branch May 5, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@booky10 @AoElite @retrooper