feat(bonfire): Replace async-std,async-tungstenite,async-channel. #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to modernize the bonfire service.
Async-std is an unmaintained runtime.
fastwebsockets is a much faster implementation of websockets standard compared to async-tungstenite.
Possible choice could be tokio-tungstenite, but it is still slower, albeit easier to work with.
Using tokio also allows us to later use much of the useful features, such as out-of-the box tracing integration.
This PR is draft, will mark as ready when benchmarks for bonfire are ready.
Please make sure to check the following tasks before opening and submitting a PR