Skip to content

Commit

Permalink
✨ Don't normalize S3 urls
Browse files Browse the repository at this point in the history
  • Loading branch information
asim-shrestha committed Dec 13, 2024
1 parent 561d655 commit 03ae49d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions core/harambe_core/normalize_url.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def normalize_url(path: str, base_path: str | None) -> str:
if not is_s3_url(path):
# We append actual URLs at the end of S3 urls occasionally
# Normalization will turn https:// into http:/
# TODO: When we handle dynamic downloads in our worker, we need to remove this logic
# we should also remove s3 as an allowed scheme all together
path = _normalize(path)
escaped_path = path.replace(" ", "%20")

Expand Down

0 comments on commit 03ae49d

Please sign in to comment.