🚫 Prevent email popups from mailto: and tel: links
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing certain requests
…event mailto and tel links from triggering popups
Comment on lines
+364
to
+372
| if harness == playwright_harness: | ||
| await page.wait_for_load_state("domcontentloaded") | ||
| await page.evaluate(""" | ||
| document.addEventListener('click', (event) => { | ||
| const target = event.target.closest('a[href^="mailto:"], a[href^="tel:"]'); | ||
| if (target) { | ||
| event.preventDefault(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
why do we need this if we have the route handler already?
There was a problem hiding this comment.
because the route handler will prevent the request from being sent, but it will not prevent the js code from being executed so the popup window will still appear, using this code, it will prevent the js code itself from opening a new window since its href starts with mailto or tel. @asim-shrestha
Fix string formatting in test_e2e.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MailtoTelBlockerHandlerto intercept and blockmailto:andtel:links at the network level.mailto:andtel:links.