✏️ Better HTML conversion options #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
core/harambe_core/errors.py
Outdated
| @@ -4,6 +4,13 @@ class HarambeException(Exception): | |||
| pass | |||
|
|
|||
|
|
|||
| class UnknownHTMLConverter(HarambeException): | |||
| def __init__(self, converter_type: any) -> None: | |||
There was a problem hiding this comment.
The converter_type parameter should be typed as Any instead of any.
There was a problem hiding this comment.
ellipsis is right, it should be Any from the typing module
|
|
||
| def get_html_converter( | ||
| html_converter_type: HTMLConverterType | None, | ||
| ) -> MarkdownConverter: |
There was a problem hiding this comment.
The return type of get_html_converter should be Union[HTMLToMarkdownConverter, HTMLToTextConverter] instead of MarkdownConverter.
| ) | ||
|
|
||
| assert len(observer.data) == 1 | ||
| assert observer.data[0]["text"].strip() == ( |
There was a problem hiding this comment.
The expected output in test_capture_html_table should not contain markdown syntax when using html_converter_type="text". Adjust the expected output accordingly.
awtkns
reviewed
Dec 6, 2024
awtkns
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds HTML conversion feature with markdown and text options, including error handling and tests.
html_converter_typeparameter tocapture_html()incore.pyfor specifying conversion type.UnknownHTMLConvertererror for unsupported types inget_html_converter().HTMLToMarkdownConverterandHTMLToTextConverterfor HTML to markdown and text conversion.get_html_converter()inhtml_converter/__init__.pyto select converter based on type.UnknownHTMLConverterexception inerrors.pyfor handling unknown types.test_capture_html_conversion_types()intest_e2e.pyto verify conversion to markdown and text.heading.htmlandtable.htmlfor testing.0.53.0inpyproject.tomlanduv.lock.This description was created by
for ed3ae6b. It will automatically update as commits are pushed.