Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update i18n module and adapt config folder and trad files #203

Merged
merged 16 commits into from
Jan 10, 2025
Merged

feat: update i18n module and adapt config folder and trad files #203

merged 16 commits into from
Jan 10, 2025

Conversation

timothejoubert
Copy link
Contributor

No description provided.

@timothejoubert
Copy link
Contributor Author

timothejoubert commented Dec 12, 2024 •
edited
Loading

  • i18n locale data don't persist SSR/client
  • enable detectBrowserLanguage
  • Add locale starter file for globals components (error_page, form, breadcrumb, carousel...), all the keys should be override

This was linked to issues Dec 12, 2024
I18n: update the structure #153
Closed
i18n: use user preferred language #192
Closed
@manuelodelain manuelodelain marked this pull request as draft December 13, 2024 13:06
@timothejoubert timothejoubert marked this pull request as ready for review December 13, 2024 15:53
manuelodelain
manuelodelain requested changes Dec 18, 2024
View reviewed changes
nuxt.config.ts Outdated Show resolved Hide resolved
utils/locale.ts Outdated Show resolved Hide resolved
@manuelodelain manuelodelain marked this pull request as draft December 18, 2024 08:21
@manuelodelain manuelodelain mentioned this pull request Dec 18, 2024
Closed
@manuelodelain manuelodelain self-assigned this Jan 9, 2025
@manuelodelain manuelodelain marked this pull request as ready for review January 10, 2025 15:35
@manuelodelain manuelodelain removed their request for review January 10, 2025 15:37
@manuelodelain manuelodelain self-requested a review January 10, 2025 15:38
@manuelodelain manuelodelain merged commit 2a2c9fe into main Jan 10, 2025
4 checks passed
@manuelodelain manuelodelain deleted the feature/update-i18n branch January 10, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illawind Illawind Illawind approved these changes

@manuelodelain manuelodelain manuelodelain approved these changes

Assignees

@manuelodelain manuelodelain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n: use user preferred language I18n: update the structure
3 participants
@timothejoubert @manuelodelain @Illawind