Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved front animations frames to gSpeciesInfo #5605

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Moved front animations frames to gSpeciesInfo #5605

merged 5 commits into from
Jan 20, 2025

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Oct 27, 2024 •
edited
Loading

Description

Penultimate remaining thing to move to gSpeciesInfo.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo marked this pull request as draft October 27, 2024 21:06
@AsparagusEduardo AsparagusEduardo changed the title Renamed folders and symbols to match species defines Moved front animations frames to gSpeciesInfo Oct 27, 2024
@AsparagusEduardo AsparagusEduardo added this to the 1.10 milestone Oct 27, 2024
@AsparagusEduardo AsparagusEduardo force-pushed the _RHH/pr/upcoming/gSpeciesInfoAnimations branch from 80957a4 to 1a2640a Compare October 29, 2024 15:55
@AsparagusEduardo
Copy link
Collaborator Author

Rebased to latest upcoming, keeping only the relevant commits.

@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review October 29, 2024 15:56
@Bassoonian
Copy link
Collaborator

Any chance we could get a migration script for this?

@AsparagusEduardo AsparagusEduardo mentioned this pull request Nov 10, 2024
Closed
20 tasks
@AsparagusEduardo
Copy link
Collaborator Author

Any chance we could get a migration script for this?

#5654

@AlexOn1ine AlexOn1ine removed this from the 1.10 milestone Nov 27, 2024
@AsparagusEduardo
Copy link
Collaborator Author

Solved conflicts

@AlexOn1ine AlexOn1ine assigned AlexOn1ine and pkmnsnfrn and unassigned AlexOn1ine Jan 4, 2025
pkmnsnfrn
pkmnsnfrn approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@pkmnsnfrn pkmnsnfrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out the overworld animations for Sneasel, Pikachu and Medicham's OW follower sprites. Their gender differences looked correct and I didn't notice any issues when running around.

@pkmnsnfrn pkmnsnfrn merged commit 3cdcb4b into rh-hideout:upcoming Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkmnsnfrn pkmnsnfrn pkmnsnfrn approved these changes

Assignees

@pkmnsnfrn pkmnsnfrn

Labels
type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AsparagusEduardo @Bassoonian @pkmnsnfrn @AlexOn1ine @hedara90