-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added installation of OSD in GCP using OCM CLI #197
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this out into two separate guides? In many of the steps, it mentions "depending on how you do things" which to me would be much clearer if it was split out into: CLI and GUI options.
@michaelryanmcneill makes sense also for me. I'll split in two different guides for clarification. Thanks for your inputs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked on the wrong button to approve 🤦 See previous comment above: Can we split this out into two separate guides? In many of the steps, it mentions "depending on how you do things" which to me would be much clearer if it was split out into: CLI and GUI options.
@michaelryanmcneill sorry for the late reply. I've divided into two guides (GUI and CLI) the installation of the cluster, and I've reviewed the result with jekyll serve locally. Kindly review |
@michaelryanmcneill kindly review with the last changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update file names, front matter, and section pages according to the new contributors guide. https://github.com/rh-mobb/documentation/blob/main/CONTRIBUTING.md
@paulczar adjusted to the proper content to fit with the new contributors guide. Adjusted the hierarchy and the content of the landing page for GCP. Checked with hugo serve locally and all seems to render properly. |
Automated the installation of OSD in GCP using OCM CLI.