Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added installation of OSD in GCP using OCM CLI #197

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

rcarrata
Copy link
Contributor

@rcarrata rcarrata commented Aug 2, 2022

Automated the installation of OSD in GCP using OCM CLI.

@rcarrata rcarrata requested a review from paulczar August 2, 2022 15:49
@michaelryanmcneill michaelryanmcneill self-requested a review August 3, 2022 17:17
Copy link
Contributor

@michaelryanmcneill michaelryanmcneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this out into two separate guides? In many of the steps, it mentions "depending on how you do things" which to me would be much clearer if it was split out into: CLI and GUI options.

@rcarrata
Copy link
Contributor Author

rcarrata commented Aug 5, 2022

@michaelryanmcneill makes sense also for me. I'll split in two different guides for clarification. Thanks for your inputs!

michaelryanmcneill
michaelryanmcneill approved these changes Sep 23, 2022
Copy link
Contributor

@michaelryanmcneill michaelryanmcneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked on the wrong button to approve 🤦 See previous comment above: Can we split this out into two separate guides? In many of the steps, it mentions "depending on how you do things" which to me would be much clearer if it was split out into: CLI and GUI options.

@rcarrata
Copy link
Contributor Author

@michaelryanmcneill sorry for the late reply. I've divided into two guides (GUI and CLI) the installation of the cluster, and I've reviewed the result with jekyll serve locally. Kindly review

@rcarrata
Copy link
Contributor Author

@michaelryanmcneill kindly review with the last changes :)

Copy link
Contributor Author

@rcarrata rcarrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@paulczar paulczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update file names, front matter, and section pages according to the new contributors guide. https://github.com/rh-mobb/documentation/blob/main/CONTRIBUTING.md

@rcarrata
Copy link
Contributor Author

@paulczar adjusted to the proper content to fit with the new contributors guide. Adjusted the hierarchy and the content of the landing page for GCP. Checked with hugo serve locally and all seems to render properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants