Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Add "view entire file" tabs to tech exercises #606

Open
wants to merge 7 commits into
base: na-jan-2021-updates
Choose a base branch
from

Conversation

jacobsee
Copy link
Member

These let you see what the entire file should look like once you've made the appropriate edits, to help out with misunderstandings about where things go, bracket problems, etc. Should reduce the amount of "simple mistakes".

Rendered example:

Screen Shot 2021-01-26 at 10 11 31 PM

@jacobsee jacobsee marked this pull request as draft January 27, 2021 06:14
@jacobsee
Copy link
Member Author

Leaving as a draft pending a conversation tomorrow.

@jacobsee jacobsee mentioned this pull request Feb 2, 2021
@jacobsee jacobsee marked this pull request as ready for review February 4, 2021 18:21
@eformat
Copy link
Member

eformat commented Feb 10, 2021

woot ... this is really good @jacobsee .. should merge this into master at some point

@eformat eformat added the enhancement New feature or request label Feb 11, 2021
@paulbarfuss
Copy link

Hey @jacobsee @eformat @sdstolworthy just wanted to leave a quick review.

Looks like overwhelmingly positive comments for the quality of work and the need to get this into enablement-docs. Can we get this PR'd into master and gh-pages branches please? I am not sure if there is any other benefit to the current target branch but would love to have this for upcoming DO500s based on feedback from recent classes.

I am happy to help review and test the changes.

@sdstolworthy
Copy link
Contributor

Agreed. Would love to see this get merged in.

@jacobsee
Copy link
Member Author

@sdstolworthy This includes your changes from #607... Is everything there ready to go as well? I'm fine with getting this merged into a main branch sooner rather than later but also not sure that we should rush this (and everything that will be pulled along with it) for use next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants