Skip to content

Commit

Permalink
Fix APRS-IS parameter sets.
Browse files Browse the repository at this point in the history
A bug in the refactored code that made it into the final release
resulted in APRS-IS being completely non-functional. This has been
resolved by adding the parameter set names back to Send-APRSThing.
  • Loading branch information
rhymeswithmogul committed Mar 21, 2023
1 parent 4b81a33 commit 609ed0b
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 2 deletions.
4 changes: 2 additions & 2 deletions APRSMessenger.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
RootModule = 'src/APRSMessenger.psm1'

# Version number of this module.
ModuleVersion = '1.0.0'
ModuleVersion = '1.0.1'

# Supported PSEditions
CompatiblePSEditions = @('Core','Desktop')
Expand Down Expand Up @@ -120,7 +120,7 @@ PrivateData = @{
IconUri = 'https://raw.githubusercontent.com/rhymeswithmogul/APRSMessenger/main/icon/APRSMessenger.png'

# ReleaseNotes of this module
ReleaseNotes = 'Initial release'
ReleaseNotes = 'Bug fixes. Should have been the initial release. My bad.'

# Prerelease string of this module
# Prerelease = ''
Expand Down
5 changes: 5 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Change Log for APRSMessenger

## Version 1.0.1 (March 20, 2023)
- FIX: Fixed a bug where APRS packets would be printed to the screen instead of sent to the network.
- FIX: Added change log and news to module manifest.
- ENHANCEMENT: More debugging output.

## Version 1.0.0 (March 19, 2023)
- Initial release.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# News for APRSMessenger

## Version 1.0.1 (March 20, 2023)
- Fixed a very embarrassing bug where APRS messages wouldn't be sent to the APRS-IS network. Oops.

## Version 1.0.0 (March 19, 2023)
- Initial release.
15 changes: 15 additions & 0 deletions src/APRSMessenger.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,19 @@ Function Send-APRSThing
[Parameter(Mandatory, Position=2)]
[String] $Message,

[Parameter(ParameterSetName="APRS-IS")]
[ValidateSet(
'asia.aprs2.net', 'aunz.aprs2.net', 'euro.aprs2.net',
'noam.aprs2.net', 'rotate.aprs2.net', 'soam.aprs2.net'
)]
[String] $Server = 'rotate.aprs2.net',

[Parameter(ParameterSetName="APRS-IS")]
[ValidateNotNullOrEmpty()]
[ValidateRange(1,65535)]
[UInt16] $Port = 14580,

[Parameter(ParameterSetName="APRS-IS")]
[Switch] $Force
)

Expand Down Expand Up @@ -136,7 +139,10 @@ Function Send-APRSMessage
'Port' = $Port
'Force' = $Force
'WhatIf' = $WhatIfPreference
'Verbose' = $VerbosePreference
'Debug' = $DebugPreference
}
Write-Debug "From:$From To:$To Msg:$Message - Server:${Server}:$Port (Force:$Force)"
Return (Send-APRSThing @Arguments)
}

Expand Down Expand Up @@ -186,7 +192,10 @@ Function Send-APRSBulletin
'Port' = $Port
'Force' = $Force
'WhatIf' = $WhatIfPreference
'Verbose' = $VerbosePreference
'Debug' = $DebugPreference
}
Write-Debug "From:$From To:BLN$BulletinID Msg:$Message - Server:${Server}:$Port (Force:$Force)"
Return (Send-APRSThing @Arguments)
}

Expand Down Expand Up @@ -240,7 +249,10 @@ Function Send-APRSGroupBulletin
'Port' = $Port
'Force' = $Force
'WhatIf' = $WhatIfPreference
'Verbose' = $VerbosePreference
'Debug' = $DebugPreference
}
Write-Debug "From:$From To:BLN$BulletinID$GroupName Msg:$Message - Server:${Server}:$Port (Force:$Force)"
Return (Send-APRSThing @Arguments)
}

Expand Down Expand Up @@ -289,7 +301,10 @@ Function Send-APRSAnnouncement
'Port' = $Port
'Force' = $Force
'WhatIf' = $WhatIfPreference
'Verbose' = $VerbosePreference
'Debug' = $DebugPreference
}
Write-Debug "From:$From To:BLN$AnnouncementID Msg:$Message - Server:${Server}:$Port (Force:$Force)"
Return (Send-APRSThing @Arguments)
}

Expand Down

0 comments on commit 609ed0b

Please sign in to comment.