Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing codebase #6

Open
wants to merge 13 commits into
base: v2/main
Choose a base branch
from

Conversation

jamiepollock
Copy link
Member

@jamiepollock jamiepollock commented May 12, 2023

In this PR I've modernized some of the aspects of the codebase. E.g. file-scoped namespaces as well as adding a blank EOL.

The latter is unrelated, more of a styling choice.

I've stopped short of adding nullability. That's a larger change which could be tackled in a separate PR.

Copy link
Contributor

@Nicholas-Westby Nicholas-Westby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this in detail, but feel free to merge it whenever. I don't understand what you mean by "adding a blank EOL", but I'm sure it's fine whatever it is.

@jamiepollock
Copy link
Member Author

@Nicholas-Westby that’s a git convention. I think I meant EOF end of file… leaving an empty EOF line. Most clients like Sourcetree flag this as missing.

@Nicholas-Westby
Copy link
Contributor

@jamiepollock If you are referring to the blank line at the end of a file, I think that used to be a thing with C/C++, but never really C# for weird compiler reasons. Doubt it's relevant today. If it's instead some invisible "end of file" character that isn't just a blank line, that may be fine. I wouldn't recommend applying this to a bunch of repos without further discussion though (e.g., to talk about usefulness).

@jamiepollock
Copy link
Member Author

@Nicholas-Westby I agree. I think we should discuss this on Monday. I'll look at ways of removing this behavior from Sourcetree if possible. We should have a consensus at least.

I may amend the PR and rollback that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants