Add code owners #17
Closed
Add code owners #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UI makes two requests - the initial incremental loading request (limit is 100 to show something quickly) - one more for actual incremental processing (limit is 1/4 of total). should be followed by another 3 requests for remaining resources - What currently happens - url contains duplicated `?` in url leading to limit being ignored - both requests will fetch ALL resources - so x2 requests to fetch ALL resources - what should happen - first request of 100 returns quickly, shows stuff on page - next request gets the first `next` url to iterate through pages - next three requests iterate through pages
- remove reference to Dockerfile.dev - move unsupported build steps from public docs to repo docs - add unsupported info to other files in repo docs
…ettings_tests improvements and fix flaky global settings tests
…ackport-issues Add `[zube]: Backlog` label to backported issues
Tidy up docs related to build
…ding Fix incremental loading
Update Pull Request template
* amazon ec2 rke2 cluster tests * update saveAndWaitForRequest fn * add loading po and use in test * updates per change requests --------- Co-authored-by: Yonas Berhe <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Fix e2e nav items selector and suspend Istio nav item check
- Improve performance of allTypes fn - This consumed the majority of time within getGroups - Reduced execution time by a half - Change from running allTypes products * modes times, run it once per product - Reduce the amount of times getGroups is called
- fix / update comments - allNavLinksKey --> allNavLinksIds - remove horrible `typeof this.type.count !== 'undefined'`
…ents-pr Improve getGroups performance
- Ensure all checkboxes can be ticked
Updates to PR checklist
nwmac
approved these changes
Feb 13, 2024
richard-cox-test
approved these changes
Feb 13, 2024
nwmac
approved these changes
Feb 13, 2024
nwmac
approved these changes
Feb 13, 2024
richard-cox-test
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video