Add support for options with spaces to riemann-wrapper
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `riemann-wrapper` is used with a configuration file (and only in this case), it is not possible to prevent splitting of options containing spaces, adding an arbitrary constraint for the user if they want to pass options with spaces (e.g. when passing a custom format string to a tool). Rework options splitting when reading options from a file, so that the user can: * quote part of the string (i.e. `options: --format='foo bar'`); * escape spaces (i.e. `options: --format=foo\ bar`). The above examples are evaluated as an array with a single string item: `["--format=foo bar"]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
riemann-wrapperis used with a configuration file (and only inthis case), it is not possible to prevent splitting of options
containing spaces, adding an arbitrary constraint for the user if they
want to pass options with spaces (e.g. when passing a custom format
string to a tool).
Rework options splitting when reading options from a file, so that the
user can:
options: --format='foo bar');options: --format=foo\ bar).The above examples are evaluated as an array with a single string item:
["--format=foo bar"].