Allow passing options to riemann-bench
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other clients, riemann-bench only support a connection to riemann using default parameters and has no way to tune it. Use the same pattern as used in other tools so that we have a unified command line interface accross tools.
|
Nice. |
Recent versions of Sinatra ensure the requested hostname is allowed and return a 403 error if not. This trigger in CI because we use custom host names rather than localhost. See: sinatra/sinatra#2053 Allow any domain as this is used for testing and we are not concerned by the security vulnerability this change upstream is meant to fix.
smortex
force-pushed
the
improve-riemann-bench
branch
from
26d996a to
0d74d5c
Compare
|
I finally found the root cause of the failure \o/ This is ready for review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other clients, riemann-bench only support a connection to riemann
using default parameters and has no way to tune it.
Use the same pattern as used in other tools so that we have a unified
command line interface accross tools.