-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbosity and error handling improvements in bulk_register #50
Verbosity and error handling improvements in bulk_register #50
Conversation
I'm not a fan of progress bars, but if we're going to add one it seems like it makes sense to use |
Though doing an informative error message certainly makes sense, it feels like it would be good to find an actual solution to the conformer hashing problem. There's really no reason for us to be storing the whole string of coordinates as a hash (this was just me not thinking through the consequences completely), we could just generate the SHA256 from the string and store that instead. It would help keep the database size down too, and that's not a terrible thing. It would be a separate PR and would require having some code to transition existing lwreg installs, but that's not a big deal. We can quickly talk about it later this week with @brje01 and I'll do that PR. |
I did it in my own fork with |
As we discussed, I agree that making the argument naming scheme consistent is a good idea (even though it's a bit of a disrupitive change). The tutorial and demo notebooks also need to be updated to reflect that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Multiple small improvements to the verbosity and error prints in the function bulk_register
tqdm
bar function is added