Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container deployment github workflow and production image. #62

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hmacdope
Copy link

Fixes #61

  • Changes the Dockerfile to mamba
  • Adds a container deployment workflow. You can also make this tagged for releases only.

@hmacdope hmacdope changed the title Switch Dockerfile to mamba and add container deployment github workflow. Add container deployment github workflow and production image. Aug 26, 2024
@greglandrum
Copy link
Contributor

@hmacdope the changes here look ok to me. I will try doing the docker build myself to confirm that everything looks good when I'm back at a real computer.

A question and a suggestion:

  1. The deploy_docker action you added looks like it needs credentials. Are we going to have to set that up somewhere?
  2. Suggestion: I think it would help to have something in the README for the Dockerfile that shows a simple example or two of how to use the image once you've installed it.

@hmacdope
Copy link
Author

@hmacdope the changes here look ok to me. I will try doing the docker build myself to confirm that everything looks good when I'm back at a real computer.

A question and a suggestion:

  1. The deploy_docker action you added looks like it needs credentials. Are we going to have to set that up somewhere?

It does look like that, but no because the action runs with github permissions scoped to this repo it can publish packages scoped to this repo without credentials.

  1. Suggestion: I think it would help to have something in the README for the Dockerfile that shows a simple example or two of how to use the image once you've installed it.

This is a good idea! Do you have any specific suggestions of what you would like to see? You are probably best placed to understand what is a good demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some improvements to Dockerfile + container deployment?
2 participants