Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(go-cache): moved dependency compiling to before the #157

Closed
wants to merge 1 commit into from
Closed

refactor(go-cache): moved dependency compiling to before the #157

wants to merge 1 commit into from

Conversation

GustavoAT
Copy link
Collaborator

@GustavoAT GustavoAT commented Feb 7, 2025 •
edited
Loading

moved dependency compiling to before the cache search to assure the changes on the go.sum, used on the cache key

🚦 Quality checklist

  • Did you add the changes in the CHANGELOG.md?

@GustavoAT GustavoAT requested a review from rios0rios0 February 7, 2025 11:27
@GustavoAT GustavoAT self-assigned this Feb 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rios0rios0
rios0rios0 requested changes Feb 10, 2025
View reviewed changes
Copy link
Owner

@rios0rios0 rios0rios0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way the cache will be always ignored, because you are always downloading the dependencies.

@GustavoAT
Copy link
Collaborator Author

Wrong approach

@GustavoAT GustavoAT closed this Feb 10, 2025
@GustavoAT GustavoAT deleted the refactor/go-cache branch February 10, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rios0rios0 rios0rios0 rios0rios0 requested changes

Assignees

@GustavoAT GustavoAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GustavoAT @rios0rios0